gtk+3: update to 3.24.24. #27032
Merged
gtk+3: update to 3.24.24. #27032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
commented
Dec 8, 2020
srcpkgs/gtk-layer-shell/template
Outdated
| build_style=meson | ||
| build_helper="gir" | ||
| configure_args="-Dtests=true" |
There was a problem hiding this comment.
cc @travankor, do_check() was failing for me without this.
There was a problem hiding this comment.
if [ "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=true"
fiis probably a better bet, so we only enable tests when somebody is actually running them.
There was a problem hiding this comment.
Good call, pushed your suggestion
ahesford
requested changes
Dec 8, 2020
srcpkgs/gtk-layer-shell/template
Outdated
| build_style=meson | ||
| build_helper="gir" | ||
| configure_args="-Dtests=true" |
There was a problem hiding this comment.
if [ "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=true"
fiis probably a better bet, so we only enable tests when somebody is actually running them.
Also enable building tests if needed.
|
I've been running this for a while now, with no issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.