Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapper: add dbus dependency #27049

Closed
wants to merge 2 commits into from
Closed

snapper: add dbus dependency #27049

wants to merge 2 commits into from

Conversation

Mek101
Copy link
Contributor

@Mek101 Mek101 commented Dec 9, 2020

Snapper requires dbus to work, as reported in #27047

Snapper requires dbus to work, as reported in #27047
@ericonr
Copy link
Member

ericonr commented Dec 9, 2020

The commit style is snapper: add dbus dependency

You need to increase the revision for this to build a new package, and dbus needs to go in depends. hostmakedepends and makedepends are build time only.

@Mek101 Mek101 changed the title Added snapper missing dependency: dbus snapper: add dbus dependency Dec 9, 2020
@ericonr
Copy link
Member

ericonr commented Dec 9, 2020

If you want to include a post installation, this is your chance. Otherwise I have a version of your commits fixed up locally that i can merge.

(you should note that PR title is a different thing from commit message)

ericonr pushed a commit to ericonr/void-packages that referenced this pull request Dec 9, 2020
Snapper requires dbus to work, as reported in void-linux#27047.

Closes: void-linux#27049 [via git-merge-pr]
@Mek101
Copy link
Contributor Author

Mek101 commented Dec 10, 2020

Sorry, you can merge

@ericonr ericonr closed this in c4852a6 Dec 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants