Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: update to 3.1.0 #27168

Closed
wants to merge 1 commit into from

Conversation

yopito
Copy link
Contributor

@yopito yopito commented Dec 15, 2020

No description provided.

@yopito
Copy link
Contributor Author

yopito commented Dec 15, 2020

test 32 fails with GH actions, can't reproduce locally, since all tests are OK.
I will push force to trigger another build

Edit: formating

@yopito
Copy link
Contributor Author

yopito commented Dec 15, 2020

fail again. code of test 32:

113 static void check_csync_vio_opendir_perm(void **state)
114 {   
115     auto *csync = (CSYNC*)*state;
116     csync_vio_handle_t *dh = nullptr;
117     int rc = 0;
118     mbchar_t *dir = c_utf8_path_to_locale(CSYNC_TEST_DIR);
119     
120     assert_non_null(dir);
121     
122     rc = _tmkdir(dir, (S_IWUSR|S_IXUSR));   /* macro: => mkdir(dir, (S_IWUSR|S_IXUSR)) */
123     assert_int_equal(rc, 0);
124 
125     dh = csync_vio_opendir(csync, CSYNC_TEST_DIR);
126     assert_null(dh);
127     assert_int_equal(errno, EACCES);
128 
129     _tchmod(dir, MKDIR_MASK);
130     c_free_locale_string(dir);
131 }

The default umask is probably kind of special in GH actions's container, that would explain this (unrelevant) error ?

@ericonr
Copy link
Member

ericonr commented Dec 15, 2020

If you feel like trying it, you could use umask from inside the shell to see if it works? Or just disable/patch the test to do that.

@ericonr ericonr closed this in 6f727d6 Dec 17, 2020
@ericonr
Copy link
Member

ericonr commented Dec 17, 2020

Don't think we should hold the update on this test. Maybe for next release :)

Also corrected a tiny typo.

@yopito yopito deleted the nextcloud.310 branch December 17, 2020 20:51
@yopito
Copy link
Contributor Author

yopito commented Dec 17, 2020

@ericonr : thanks for the typo fix and the merge.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants