giggle: fix cross, crash #27179
Merged
giggle: fix cross, crash #27179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm how does the cross patch work to fix? What seems to be doing is removing stuff related to time? |
By not depends on |
ericonr
reviewed
Dec 17, 2020
srcpkgs/giggle/patches/cross.patch
Outdated
| return tm; | ||
| #else | ||
| struct tm *tm = g_new0 (struct tm, 1); | ||
| + long ltime; |
There was a problem hiding this comment.
#include <stdio.h>
int main()
{
printf("%ld\n", sizeof(long));
}
on my rpi prints 4, so I think it'd be more correct to use long long here.
There was a problem hiding this comment.
Make sense, the original code is cursed.
There was a problem hiding this comment.
Anyway, correct format specifier for size_t is zu :-p
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #27151
@ndowens