Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: update to 1.4.8 #27253

Closed
wants to merge 1 commit into from
Closed

zstd: update to 1.4.8 #27253

wants to merge 1 commit into from

Conversation

r-ricci
Copy link
Contributor

@r-ricci r-ricci commented Dec 18, 2020

No description provided.

@r-ricci
Copy link
Contributor Author

r-ricci commented Dec 18, 2020

do_check() is failing on the (i686, i686, 1) build. I tested locally on x86_64-glibc with a i686 masterdir, but I cannot reproduce the failure.

EDIT: I forgot to checkout the right branch. I can reproduce, but I don't know what is the problem.

@pullmoll
Copy link
Member

The check prints the problem:

zstd: util.c:351: readLinesFromFile: Assertion `pos + lineLength < dstCapacity' failed.

Seems like this could be an integer overrun. Hint: sizeof(long) is 4 for 32 bit vs. 8 for 32 bit.
No time to further investigate this, though.

@ericonr
Copy link
Member

ericonr commented Dec 18, 2020

I will try to check upstream.

@r-ricci
Copy link
Contributor Author

r-ricci commented Dec 18, 2020

The problem was fixed here.

@ericonr
Copy link
Member

ericonr commented Dec 18, 2020

I think they are going to make a hot fix release, we can probably wait for that. It's good that their code caught alignment issues; on i686 it's indeed not an issue, but it could kill the process with SIGBUS on armv*

@r-ricci r-ricci changed the title zstd: update to 1.4.7. zstd: update to 1.4.8 Dec 19, 2020
@ericonr ericonr closed this in 4e27ede Dec 20, 2020
@ericonr
Copy link
Member

ericonr commented Dec 20, 2020

I fixed the commit message before pushing, thanks!

@r-ricci r-ricci deleted the zstd-1.4.7 branch December 20, 2020 11:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants