Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox-ose: fix DKMS w/ linux-5.10; dbus hint #27256

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

pullmoll
Copy link
Member

@pullmoll pullmoll commented Dec 18, 2020

Fix DKMS with linux-5.10 and add check for dbus from #25277.

Closes: #25277

[ci skip]

https://www.virtualbox.org/ticket/20055
DKMS builds but is not yet tested because I can't currently boot into 5.10. Anyone?

@pullmoll
Copy link
Member Author

Ok, now tested on another machine which I upgraded to linux-5.10.1.There I created a Void Linux VM and installed the XFCE ISO, updated system etc. Seems to be working at least for Void as guest.

Any objections for the dbus check? Otherwise I'd merge this.

@ericonr
Copy link
Member

ericonr commented Dec 18, 2020

What information does the D-Bus check add? From what I understand, the service already dies by itself if D-Bus isn't available...

Maybe a comment that it requires D-Bus would achieve the same purpose.

@pullmoll
Copy link
Member Author

pullmoll commented Dec 18, 2020

Well, I don't care and saw no comment on the original PR. I can just remove it if you think it's redundant.
Or write a line

# Note: requires dbus service

in the .../run file.

Fix DKMS with linux-5.10 and add a hint for dbus requirement.

Closes: void-linux#25277

[ci skip]
@pullmoll pullmoll changed the title virtualbox-ose: fix DKMS w/ linux-5.10; dbus check virtualbox-ose: fix DKMS w/ linux-5.10; dbus hint Dec 18, 2020
@pullmoll pullmoll merged commit 538ca4e into void-linux:master Dec 18, 2020
@pullmoll pullmoll deleted the virtualbox-ose-linux-5.10 branch December 18, 2020 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants