Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: qt6 #27349

Merged
merged 20 commits into from May 6, 2021
Merged

New packages: qt6 #27349

merged 20 commits into from May 6, 2021

Conversation

Johnnynator
Copy link
Member

@Johnnynator Johnnynator commented Dec 22, 2020

TOOD:

  • Address TODOs

the cmake part does not use the host version of some tools e.g. a problem with lconvert fixed with 6.1.0

[ci skip]

@Johnnynator Johnnynator changed the title common/build-style/cmake.sh: pass full path of TOOLCHAIN_FILE to cmake [WIP] New packages: qt6 Dec 22, 2020
@Johnnynator Johnnynator added new-package This PR adds a new package WIP Work in progress labels Dec 22, 2020
@ericonr
Copy link
Member

ericonr commented Dec 22, 2020

Missing libatomic from armv6l. Do you know why armv6l doesn't get this error, only armv6l-musl?

@Johnnynator
Copy link
Member Author

Missing libatomic from armv6l. Do you know why armv6l doesn't get this error, only armv6l-musl?

armv6l does error, you just didn't see it, since CI doesn't run for armv6l

checksum=3884c64750a9b6ef544ee2fb72a2bf5e5e167501d6ea11ab1a55105e354a506e
python_version=3

# TODO: fix usage of ccache
Copy link
Contributor

@yopito yopito May 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look on qt6-base and cmake and ccache. here my points:

"-D-DQT_USE_CCACHE" has no effect if ccache is enabled from xbps-src : ccache will be used.
I think "-DQT_USE_CCACHE=OFF" might be a better idea (similar to other packages)

qt6-base build uses precompiled headers (pch) when working with automoc. ccache does not handle pch until some additional configuration (see https://ccache.dev/manual/4.2.1.html#_precompiled_headers).
=> so ccache is rather useless in this case: about 150/1160 "objects" are stored in ccache
workarounds:

  • hope that packagers will enable pch support in ccache. IMHO, this support is somewhat imprecise, afraid of false positive
  • disable use of pch for building qt6-base with "-DBUILD_WITH_PCH=OFF" : some overhead (not that much) on first build, but ccache efficiency after (about 70 minutes on 1st run, 6 minutes then to build+package qt6-base). And no specific ccache settings is needed

common/build-style/cmake.sh Outdated Show resolved Hide resolved
@Johnnynator Johnnynator changed the title [WIP] New packages: qt6 New packages: qt6 May 6, 2021
@Johnnynator Johnnynator removed the WIP Work in progress label May 6, 2021
@Johnnynator Johnnynator merged commit b80014e into void-linux:master May 6, 2021
@Johnnynator Johnnynator deleted the qt6 branch May 6, 2021 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants