-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvwm-git: fix cross-build #27436
mvwm-git: fix cross-build #27436
Conversation
From 53b028752d6fdd96471be8cd4c3d1c8d490df2a5 Mon Sep 17 00:00:00 2001 | ||
From: Nathan Owens <ndowens@artixlinux.org> | ||
Date: Fri, 25 Dec 2020 19:45:56 -0600 | ||
Subject: [PATCH] Fix cross-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to upstream this? Would be nice to not have to rebase and add new changes when there are updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. Add this to my TODO list :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, upstream seems inactive since 2015... I'd consider dropping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, the patch likely won't become stale, so it wouldn't be so bad to add it.
my_LIBS="$LIBS" | ||
CPPFLAGS="$CPPFLAGS $png_CFLAGS" | ||
LIBS="$LIBS $png_LIBS -lz -lm" | ||
- AC_TRY_RUN([#include <png.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to minimize that patch we have. Let's say by only change AC_TRY_RUN
to AC_TRY_COMPILE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing that causes:
configure.ac:113: error: possibly undefined macro: AC_DEFINE If this token and others are legitimate, please use m4_pattern_allow.
No description provided.