Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvwm-git: fix cross-build #27436

Closed
wants to merge 1 commit into from
Closed

mvwm-git: fix cross-build #27436

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Dec 26, 2020

No description provided.

@ndowens ndowens marked this pull request as draft December 26, 2020 02:00
Comment on lines +1 to +4
From 53b028752d6fdd96471be8cd4c3d1c8d490df2a5 Mon Sep 17 00:00:00 2001
From: Nathan Owens <ndowens@artixlinux.org>
Date: Fri, 25 Dec 2020 19:45:56 -0600
Subject: [PATCH] Fix cross-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to upstream this? Would be nice to not have to rebase and add new changes when there are updates.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. Add this to my TODO list :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, upstream seems inactive since 2015... I'd consider dropping.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, the patch likely won't become stale, so it wouldn't be so bad to add it.

my_LIBS="$LIBS"
CPPFLAGS="$CPPFLAGS $png_CFLAGS"
LIBS="$LIBS $png_LIBS -lz -lm"
- AC_TRY_RUN([#include <png.h>
Copy link
Member

@sgn sgn Dec 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to minimize that patch we have. Let's say by only change AC_TRY_RUN to AC_TRY_COMPILE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that causes:
configure.ac:113: error: possibly undefined macro: AC_DEFINE If this token and others are legitimate, please use m4_pattern_allow.

@sgn sgn mentioned this pull request Dec 26, 2020
@sgn sgn closed this in #27439 Dec 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants