Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd-lts update to 4.0.4 + Sqlite replication drop #27444

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

fosslinux
Copy link
Contributor

lxd-lts update is to drop the need for sqlite-replication in the template.

sqlite-replication has not been needed for some time after dqlite moved to mainstream sqlite.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I can't evaluate the resulting package.

@CameronNemo ?

@CameronNemo
Copy link
Contributor

removed packages need special care but I do not know the specifics of that. Looks fine to me.

@fosslinux
Copy link
Contributor Author

#23575 is where we do that

@ericonr
Copy link
Member

ericonr commented Jan 22, 2021

Does sqlite-replication need special handling in removed-packages? (or to be handled there at all?)

@fosslinux
Copy link
Contributor Author

Yes, it does now that it exists, done.

@ericonr ericonr merged commit 50864d3 into void-linux:master Jan 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants