Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: Direwolf #27510

Closed
wants to merge 1 commit into from
Closed

Conversation

DavidKaep
Copy link

This is a template for Direwolf, a ham radio ax.25 software tnc.

@ericonr ericonr added the new-package This PR adds a new package label Dec 28, 2020
if [ "$CROSS_BUILD" ]; then
vsed -i CMakeLists.txt -e '10aset(RUN_NEON "advanced")'
fi
vsed -i conf/CMakeLists.txt -e 's/\/etc\/udev\/rules.d\//\/usr\/lib\/udev\/rules.d/g'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier to use a separator other than / here... something like s,things,things,

@ericonr
Copy link
Member

ericonr commented Dec 28, 2020

[  1%] Building C object external/geotranz/CMakeFiles/geotranz.dir/error_string.c.o
/builddir/direwolf-1.6/src/direwolf.h:302:56: error: expected declaration specifiers or '...' before string constant
  302 | #define strlcat(dst,src,siz) strlcat_debug(dst,src,siz,__FILE__,__func__,__LINE__)
      |                                                        ^~~~~~~~

musl actually provides strlcat and strlcpy...

srcpkgs/direwolf/template Outdated Show resolved Hide resolved
@DavidKaep
Copy link
Author

Your suggestioin worked perfectly I moved everything into patches and now it works on musl as well.

@DavidKaep DavidKaep changed the title [WIP] New Package: Direwolf New Package: Direwolf Dec 29, 2020
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be New package: direwolf- 1.6

Please open a bug report with upstream about musl compatibility.

Comment on lines +8 to +13
# install udev rules for CM108
if(LINUX)
- install(FILES "${CUSTOM_CONF_DIR}/99-direwolf-cmedia.rules" DESTINATION /etc/udev/rules.d/)
+ install(FILES "${CUSTOM_CONF_DIR}/99-direwolf-cmedia.rules" DESTINATION /usr/lib/udev/rules.d/)
endif()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this in a separate patch, otherwise it can be removed accidentally if upstream reports that musl compat has been fixed.

set(direwolf_VERSION_PATCH "0")
set(direwolf_VERSION_SUFFIX "")

+set(RUN_NEON "advanced")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is configure_args+=" -DRUN_NEON=advanced" enough?

build_style=cmake
hostmakedepends="gcc make hamlib"
makedepends="alsa-lib-devel libudev-devel hamlib-devel"
depends="hamlib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> direwolf-1.6_1: running pre-pkg hook: 04-generate-runtime-deps ...
   SONAME: libhamlib.so.2 <-> hamlib>=3.3_1
   SONAME: libasound.so.2 <-> alsa-lib>=1.0.20_1
   SONAME: libudev.so.1 <-> eudev-libudev>=1.6_1
   SONAME: libc.so <-> musl>=1.1.21_1

The depends line isn't necessary because it's detected automatically by our build system.

version=1.6
revision=1
build_style=cmake
hostmakedepends="gcc make hamlib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hostmakedepends="gcc make hamlib"
hostmakedepends="hamlib"

gcc and make are available by default.

@github-actions
Copy link

github-actions bot commented May 1, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants