Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: genie-1141 #27915

Closed
wants to merge 1 commit into from
Closed

Conversation

ScrelliCopter
Copy link
Contributor

https://github.com/bkaradzic/GENie
Please excuse the Git, it's required by the pre-build configure scripts to set the version reported by --version. Upstream has an irritating way of designating the current stable release so something like this has to be done anyway.
I did my best to make sure the package builds & cross-compiles on every architecture xbps-src supports.

@ScrelliCopter
Copy link
Contributor Author

Spoke too soon... native 32 bit builds should be fixed now.

@ericonr ericonr added the new-package This PR adds a new package label Jan 14, 2021
srcpkgs/genie/template Outdated Show resolved Hide resolved
srcpkgs/genie/template Outdated Show resolved Hide resolved
@Chocimier
Copy link
Member

Could you ask them to tag releases?

@ScrelliCopter
Copy link
Contributor Author

Upstream is unlikely to want to use release tags while the (unmodified) build scripts require Git.

Copy link
Member

@Piraty Piraty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i put some suggestion in-code.
Afte i looked into genie's build system, I also require you to put comments on the parts where you build for the host and why, and ideally guard that by testing $CROSS_BUILD

srcpkgs/genie/template Outdated Show resolved Hide resolved
srcpkgs/genie/template Outdated Show resolved Hide resolved
@ScrelliCopter
Copy link
Contributor Author

ScrelliCopter commented Jan 28, 2021

@Piraty

Afte i looked into genie's build system, I also require you to put comments on the parts where you build for the host and why

I added a small explanation to the start of do_configure that should make the intention clear.

and ideally guard that by testing $CROSS_BUILD

I put CC="${CC_host:-$CC}" in the make that runs on the host and switched to the gnu-makefile build_style to handle the actual build. Tested & seems to work for both native & cross builds. Should that handle every case?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants