New package: makemkv-1.17.2

[jcgruenhage]

No description provided.

[Chocimier]

You shall not modify, ...

nonfree

[jcgruenhage]

YES. I remembered to put in the license, but not the nonfree, sorry.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[jcgruenhage]

Updated to a newer version to prevent this from being closed.

If someone wants to take a stab at cross compiling for aarch64 and arm6l (upstream released binaries of the closed part for these architectures as well now), that'd be cool as well, but getting this in at all would be a good first step IMO.

[Piraty]

fine with me, objections?

[Chocimier]

Isn't bundling GPL jar and proprietary binaries a GPL breach?

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[jcgruenhage]

Isn't bundling GPL jar and proprietary binaries a GPL breach?

maybe? IANAL, but it's at least a bit fishy IMO. I think it might be fine actually, but I'd need to check more into what code comes from where and who holds the copyright and such. In general, taking GPL code and building something proprietary based on it is a breach, but I don't think that's happening here. I think they are dual-licensing some parts under both their proprietary license and under the GPL, but keeping some core things to themselves which are only released under the proprietary license. If they are indeed shipping GPL code for which they have no copyright in binaries for which they don't release the full source code under the GPL, then that would be a breach, yes.

Still, I don't see any harm in shipping this as a package in non-free, right? It's being shipped by a few other distros as well, see https://repology.org/project/makemkv/versions

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[jcgruenhage]

Version bumped, not stale

[agausmann]

Would it be possible to package the GUI separately? For example, as a makemkv-qt or makemkv-gui sub-package.

[agausmann]

See b6efcf2 as an example of a separate makemkv-qt package.

I'm not very experienced with subpackages so there might be some issues with this template.

But anyway, the motivation for this is to be able to install the CLI on a headless machine without pulling in Qt.
Similar to how Transmission is split into CLI/GUI packages.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[jcgruenhage]

bump.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[Chocimier]

If they are indeed shipping GPL code for which they have no copyright

They do include Rich Wareham's libdvdnav, Håkan Hjort's libdvdread and pieces of Sun's java stdlib.
They know what they are doing, see makemkv-oss-1.17.1/mmgpl/dvdnavsrv.cpp

Still, I don't see any harm in shipping this as a package in non-free, right?

As long as you can provide full source of resulting package, IMO.

[Chocimier]

It's being shipped by a few other distros as well

Almost all or them don't host packages but instruct package manager to fetch from origin.

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.