Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action: build on push to non-master branches #28013

Merged
merged 1 commit into from Mar 27, 2022

Conversation

sgn
Copy link
Member

@sgn sgn commented Jan 18, 2021

@sgn sgn closed this Jan 18, 2021
@sgn sgn reopened this Jan 18, 2021
@sgn sgn requested a review from ericonr January 18, 2021 14:03
@sgn sgn changed the title liquid-dsp: fix build GitHub Action: build on push to non-master branches Jan 18, 2021
@ericonr
Copy link
Member

ericonr commented Jan 18, 2021

Doesn't this mean that a staging branch with huge changes will be unnecessarily running CI? I have a couple branches I keep around that I don't want to have CI run on... Opening a PR on your own repo is the simplest way of achieving this without spending a bunch of time running builds.

@sgn
Copy link
Member Author

sgn commented Jan 18, 2021

We can set the ignore to pattern matching, let's say, ignore branches with name: 'wip-*'

@sgn sgn force-pushed the liquid-dsp branch 2 times, most recently from ed93753 to 0ebbc55 Compare January 18, 2021 14:32
@ericonr
Copy link
Member

ericonr commented Jan 18, 2021

I'm concerned about people who aren't aware of this new default getting lots of notifications and spending more CI time than they expect. GH is kinda stupid as well, so it will have separate CI runs for the PR and for the branch in the person's repo.

Anyway, if you think this is useful (and I believe others have requested it as well), we can turn it on. As long as this doesn't impact us too much (by, say, counting the number of machines we are using by including forks), I think we can push as something experimental.

@fosslinux
Copy link
Contributor

Whats the liquid-dsp change?

@sgn
Copy link
Member Author

sgn commented Jan 19, 2021 via email

@ericonr
Copy link
Member

ericonr commented Feb 25, 2021

@sgn maybe we can make CI run on branches named ci-* instead? That way it's opt-in.

@sgn
Copy link
Member Author

sgn commented Feb 25, 2021

Yay, let's do that instead.

sgn added a commit to sgn/void-packages that referenced this pull request Mar 6, 2021
@the-maldridge the-maldridge merged commit b4c6ac3 into void-linux:master Mar 27, 2022
@sgn sgn deleted the liquid-dsp branch August 23, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants