New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webkit2gtk: fix bwrap-libdir32.patch #28215
Conversation
FWIW here is the list of parameters for
Unfortunately evolution still prints the error |
Ok, now it works: evolution is showing emails again. |
The LIB_DIR_WS string should be just the wordsize w/o "lib". [ci skip]
This looks like the correct fix to me, that very patch has @@ -765,9 +771,9 @@ GRefPtr<GSubprocess> bubblewrapSpawn(GSubprocessLauncher* launcher, const Proces
"--ro-bind-try", "/usr/lib", "/usr/lib",
"--ro-bind-try", "/usr/local/lib", "/usr/local/lib",
"--ro-bind-try", LIBDIR, LIBDIR,
- "--ro-bind-try", "/lib64", "/lib64",
- "--ro-bind-try", "/usr/lib64", "/usr/lib64",
- "--ro-bind-try", "/usr/local/lib64", "/usr/local/lib64",
+ "--ro-bind-try", "/lib" LIB_DIR_WS, "/lib" LIB_DIR_WS,
+ "--ro-bind-try", "/usr/lib" LIB_DIR_WS, "/usr/lib" LIB_DIR_WS,
+ "--ro-bind-try", "/usr/local/lib" LIB_DIR_WS, "/usr/local/lib" LIB_DIR_WS,
"--ro-bind-try", PKGLIBEXECDIR, PKGLIBEXECDIR,
}; |
the patch is right, but it should not really fix the problem because the "proper" libdir is already handled specially via whatever is passed from cmake (you can see that in the output) feel free to merge, though |
The LIB_DIR_WS string should be just the wordsize w/o "lib".
General
Have the results of the proposed changes been tested?
Not yet tested but I saw the wrong strings like
"/liblib64"
in an strace output.This github UI is annoyingly reluctant to updated commit msg etc. :)