New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
milkytracker: update to 1.03.00. #28224
Conversation
They are looking for SDL2 in the wrong place for cross, it seems :/ Since it used to work, you probably need to make a patch reverting some commit in their build system. |
Maybe milkytracker/MilkyTracker@87d0f55 ? But then we need to fix SDL2 / Cmake instead. |
I'll fix it as soon as possible. I simply need to apply the patch exclusively to the cross targets: the question is how do I patch the cross targets? |
Nah, it should be ok to apply it for all. Still, I'd prefer to figure out what CMake is doing wrong. |
I do not understand why this error pops up in the first place: the source tarball is the same for all targets and yet on non-ARM architectures this builds correctly. |
How CMake (and other tools) search for dependencies can change (and have flaws) when cross building. That's the main difference. The upstream commit works on native builds, but it broke something for cross. |
Imo just revert the commit. Fixing the SDL2 provided stuff is far more pain. |
Maybe I can restrict the number of architectures in the mean time so at least this package can be pushed forward, then when a fix is found (or upstream fixes this problem), I can push a new revision |
I've opened an issue to upstream, maybe they'll look into it and fix it |
I'm not sure upstream will want to fix it. The issue is how SDL2's cmake files are created, because they are using the correct way of finding the dependency. Have you tried adding a patch that reverts the commit I linked? |
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)