Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-setuptools: update to 52.0.0. #28261

Closed
wants to merge 40 commits into from

Conversation

ahesford
Copy link
Member

This release drops easy_install, which will cause hard failures when building python-module or python3-module templates that do not specify all of their setup_requires dependencies in hostmakedepends. This is a good thing; before, setuptools would fetch setup dependencies on its own, negatively impacting the reproducibility of package builds.

Still, I am going to run through rebuilds of some (most? all?) of the python3-* packages to check for build-time breakage.

@ahesford
Copy link
Member Author

ahesford commented Jan 28, 2021

Of 726 packages rebuilt through the following loop:

foreach I (srcpkgs/python3-*)
	pkg=$(basename $(realpath -e $I))
	[ -n "$pkg" ] || continue
	{ ./xbps-src show-hostmakedepends $pkg | grep -q python3-setuptools } || continue
	grep -q " $pkg\$" setuptools.dependants && continue
	if ./xbps-src pkg -f -m /tmp/masterdir.x86_64 "$pkg"; then
		echo "- [x] $pkg" >> setuptools.dependants
	else
		echo "- [ ] $pkg" >> setuptools.dependants
	fi
	./xbps-src -m /tmp/masterdir.x86_64 clean
end

The following 29 failed to rebuild:

  • python3-Flask-User
  • python3-PGPy
  • python3-aiohttp-sse-client
  • python3-alsa
  • python3-audioread
  • python-dateutil
  • python3-ffmpeg-python
  • python3-gitchangelog
  • python3-guessit
  • python3-humanize
  • python3-irc
  • python3-jaraco.classes
  • python3-jaraco.collections
  • python3-jaraco.functools
  • python3-jaraco.text
  • python3-keyring
  • python3-keyrings-alt
  • python3-keyutils
  • python3-marisa-trie
  • python3-numexpr
  • python3-pluggy
  • python3-portend
  • python3-pylast
  • python3-pysol_cards
  • python3-pytest-qt
  • python3-rebulk
  • python3-testtools
  • python3-treq
  • python3-zope.security

I'm working through this list to resolve these issues. If I'm overlooking any packages that build with setuptools, please leave a comment.

@ahesford ahesford force-pushed the setuptools branch 2 times, most recently from 3af6c46 to e54b3a7 Compare January 28, 2021 16:02
@ahesford
Copy link
Member Author

ahesford commented Jan 28, 2021

I repeated the above loop over srcpkgs/* and identified the following additional packages which fail to build:

  • duplicity
  • fava
  • khard
  • nagstamon
  • protontricks
  • python-b2sdk
  • rdiff-backup
  • terminator
  • todoman
  • whipper

Fixing these now.

This release drops easy_install, which will cause hard failures when
building python-module or python3-module templates that do not specify
all of their setup_requires dependencies in `hostmakedepends`. This is a
good thing; before, setuptools would fetch setup dependencies on its
own, negatively impacting the reproducibility of package builds.
@ahesford ahesford closed this in 0f483b8 Jan 28, 2021
@ahesford ahesford deleted the setuptools branch January 28, 2021 20:12
uw2021 pushed a commit to uw2021/void-packages that referenced this pull request Feb 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant