Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland: update to 0.19.0, adopt. #28296

Merged
merged 1 commit into from Feb 1, 2021
Merged

wayland: update to 0.19.0, adopt. #28296

merged 1 commit into from Feb 1, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Jan 29, 2021

Also fix ndebug mode with meson options instead of CFLAGS.

I don't know why -UNDEBUG was initially added, though. In 0f7885c it isn't explained.

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me (though I haven't gone through extensive testing)
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
wayland: update to 0.19.0, adopt.
1bb03c0 
Also fix ndebug mode with meson options instead of CFLAGS. Disabling
NDEBUG is necessary for the test suite to work correctly.

Thanks ifreund for pointing me in this direction.
@ericonr ericonr merged commit 939f1c6 into void-linux:master Feb 1, 2021
@ericonr ericonr deleted the wa branch February 1, 2021 02:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ericonr