Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghdl: broken if no backend available #28311

Closed
wants to merge 1 commit into from
Closed

ghdl: broken if no backend available #28311

wants to merge 1 commit into from

Conversation

sgn
Copy link
Member

@sgn sgn commented Jan 30, 2021

While we're at it, let xbps-src figure out which subpackages will be
built. I don't like unset.


@q66 feel free to revert the subpackages calculation part. Beside my dislike to unset, I think conditional definition of subpackages can reduce one warning :-p

While we're at it, let xbps-src figure out which subpackages will be
built. I don't like `unset`.
@q66
Copy link
Contributor

q66 commented Jan 30, 2021

you should never conditionally define _package functions, and the "no backend" situation is irrelevant, since the llvm backend is available pretty much always, and even in case you did compile without a backend, you'd still get a "working" package (it would contain /usr/bin/ghdl which would tell you about no backend being available)

@q66 q66 closed this Jan 30, 2021
@sgn sgn deleted the ghdl branch April 9, 2021 00:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants