Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdenlive: update to 20.12.1. #28390

Merged
merged 1 commit into from Feb 4, 2021
Merged

kdenlive: update to 20.12.1. #28390

merged 1 commit into from Feb 4, 2021

Conversation

andry-dev
Copy link
Contributor

@andry-dev andry-dev commented Feb 1, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

Build status

It doesn't build in CI because the do_check doesn't pass since there's no X session running in the container:

qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.

@ericonr
Copy link
Member

ericonr commented Feb 3, 2021

diff --git a/srcpkgs/kdenlive/template b/srcpkgs/kdenlive/template
index 8595ca6d44..1dbc21964d 100644
--- a/srcpkgs/kdenlive/template
+++ b/srcpkgs/kdenlive/template
@@ -21,3 +21,7 @@ checksum=9b6e22ad311c33457e7f7147ad873286945fc6c3b610129856fd01cbb51da458
 
 # needed for mlt to work on musl
 CXXFLAGS="-DHAVE_LOCALE_H=1"
+
+pre_check() {
+	export QT_QPA_PLATFORM=offscreen
+}

For that part, but there are still other failing tests.

@jnbr

@jnbr
Copy link
Contributor

jnbr commented Feb 3, 2021

Thanks for bumping the package.
I only had a quick look but I think the remaining fail is a bug in the test harness.
In case you don't feel like tracking this down, I recommend disabling tests, but please keep the QT_QPA_PLATFORM=offscreen.

@andry-dev
Copy link
Contributor Author

In case you don't feel like tracking this down, I recommend disabling tests

Yeah I'm kinda busy right now so I'll pass, sorry about that. To disable them I just create an empty do_check and that's it, right?

@ericonr
Copy link
Member

ericonr commented Feb 4, 2021

@andry-dev yes!

@jnbr jnbr merged commit 5372759 into void-linux:master Feb 4, 2021
@andry-dev andry-dev deleted the kdenlive branch February 4, 2021 22:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants