Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tvbrowser: depends on virtual java-runtime package. #28504

Merged
merged 1 commit into from
Feb 14, 2021
Merged

tvbrowser: depends on virtual java-runtime package. #28504

merged 1 commit into from
Feb 14, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Feb 5, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr mentioned this pull request Feb 5, 2021
Closed
@ericonr
Copy link
Member Author

ericonr commented Feb 5, 2021

Hm, this seems to work mostly because at some point the repository will already have packages that provide java-runtime and xbps-src will magically query them instead of looking through virtual or srcpkgs.

@pullmoll the solution here would be to build openjdk11 first :p

Or we make this package depend directly on opendjk11.

@ericonr
tvbrowser: depends on openjdk11.
227db00 
It is possible to depend on `java-runtime>=11`, but only if the
openjdk11 package has already been built. Until xbps-src has a mechanism
for dealing with this, and while openjdk11 is our latest java runtime,
depending directly on openjdk11 works fine.
@ericonr ericonr merged commit 9b1dff7 into void-linux:master Feb 14, 2021
@ericonr ericonr deleted the tv branch February 14, 2021 18:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ericonr