Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively minor update, but I'd appreciate a bit of testing, especially from @Anachron and @wangp who had some issues on
armv7l
oraarch64
.There is a caveat: I tried building this update while running the
smbd
andnmbd
services from the currentsamba-4.13.3_1
package. The resulting 4.13.4_1 package produced a brokensmbd
which died on startup with the errorCode 13 looks like
EACCES
, but this is a hard-coded number that is independent of the actual reason for failure.After removing
samba
,smbclient
andsamba-libs
(which also required removingcifs-utils
andvlc
on my system) and rebuilding the package,smbd
worked as expected. I tried a third rebuild withsamba
,smbclient
andsamba-libs
installed but the services not active. This also seemed to produce a working package.It seems that the build process allows the host configuration to leak through some how, and when the old services are running, something causes
smbd
to break. If you have similar troubles, I recommend first stopping anynmbd
andsmbd
and rebuilding; if that still fails, try removingsamba-libs
and any dependants.Have the results of the proposed changes been tested?