Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-style/qmake: no rpath #28563

Closed
wants to merge 2 commits into from
Closed

build-style/qmake: no rpath #28563

wants to merge 2 commits into from

Conversation

sgn
Copy link
Member

@sgn sgn commented Feb 7, 2021

Fix #27494

  • Not sure if RPATH is intentional or not?

@sgn sgn requested a review from Johnnynator February 7, 2021 11:07
Johnnynator
Johnnynator approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@Johnnynator Johnnynator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sgn
build-style/qmake: look for modules in target
b584516 
- With this added, we can remove qt5*-devel from hostmakedepends
@sgn
Copy link
Member Author

sgn commented Feb 7, 2021

I added a change to look up for qt5 modules inside target's modules directory. However the change requires #28567 merged.

sgn added a commit to sgn/void-packages that referenced this pull request Feb 8, 2021
@sgn
build-style/qmake: no rpath
f4ffbb3 
See void-linux#27494
Close void-linux#28563
@sgn sgn closed this in 596a2da Feb 8, 2021
atweiden added a commit to atweiden/voidpkgs that referenced this pull request Feb 12, 2021
@atweiden
build-style/qmake: no rpath
d3aee07 
See void-linux/void-packages#27494
Close void-linux/void-packages#28563

void-linux/void-packages@596a2da
@sgn sgn deleted the qmake-no-rpath branch April 9, 2021 00:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Johnnynator Johnnynator Johnnynator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPATH set in qjackctl breaks pw-jack
2 participants
@sgn @Johnnynator