gdm: enable smooth transition with plymouth. #28570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Feb 7, 2021
| -Dsystemd-journal=false -Dinitial-vt=7 -Dwayland-support=true | ||
| -Dselinux=disabled -Dlibaudit=disabled | ||
| -Dsystemdsystemunitdir=/tmp -Dsystemduserunitdir=/tmp" | ||
| hostmakedepends="dconf gettext itstool pkg-config" | ||
| makedepends="accountsservice-devel elogind-devel gettext-devel glib-devel | ||
| iso-codes libSM-devel libcanberra-devel nss-devel pam-devel upower-devel" | ||
| iso-codes libSM-devel libcanberra-devel nss-devel pam-devel upower-devel | ||
| plymouth-devel" |
There was a problem hiding this comment.
So it checks for the plymouth library at configure time (I could find this line), but doesn't link against it? At least I couldn't see anything about it in the CI log...
Just wondering what it is that it does with the library, and if we need any sort of warning about plymouth library revbump or such.
There was a problem hiding this comment.
It does absolutely nothing with the library, yet it requires ply-boot-client.pc to be present at configure time. Code just spawns plymouth binary and that's all.
The quirky logic comes from a patch written by Fedora devs 11 years ago. My best guess is that it was upstreamed without anyone knowing what it really did.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for smooth transition was disabled years ago, when
plymouthwasn't in the Void repo.gdmchecks whetherplymouthcan be pinged at run time so that no hard dependency is required.General
Have the results of the proposed changes been tested?