Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crda: update to 4.14 #28580

Merged
merged 1 commit into from Feb 25, 2021
Merged

crda: update to 4.14 #28580

merged 1 commit into from Feb 25, 2021

Conversation

edersohe
Copy link

@edersohe edersohe commented Feb 8, 2021

crda: update to 4.14 #28580

  • crda-4.14
  • wireless-regdb-2020.12.20

fix error messages like

[    6.954196] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
[    6.954207] cfg80211: failed to load regulatory.db

registered also in the issue #2999 and

[    6.917367] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[    6.920611] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in the commit message why you are removing the set-wireless-regdom script and the wardrive build option.

@thypon

fi
}
homepage="https://wireless.wiki.kernel.org/en/developers/regulatory/crda"
distfiles="https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/crda.git/snapshot/${pkgname}-${version}.tar.gz https://www.kernel.org/pub/software/network/wireless-regdb/${_dbname}-${_dbversion}.tar.xz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split these into two lines/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@edersohe
Copy link
Author

edersohe commented Feb 9, 2021

Please explain in the commit message why you are removing the set-wireless-regdom script and the wardrive build option.

@thypon

I changed the pull request to support wardrive build option and set-wireless-regdom through udev rule

@edersohe edersohe requested a review from ericonr February 9, 2021 06:58
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can't test myself. Thanks for looking into it :)

Pinging @thypon for a second review, otherwise can merge in a week assuming no one complains.

@edersohe
Copy link
Author

edersohe commented Feb 10, 2021

now the build avoid re-sign with a new self signed cert that causes messages like

[    6.920611] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid

@ericonr
Copy link
Member

ericonr commented Feb 10, 2021

Ah, please also fix the commit message. The title should be the same as the PR title.

* crda-4.14
* wireless-regdb-2020.12.20

fix error messages like

```
[    6.954196] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
[    6.954207] cfg80211: failed to load regulatory.db
```

registered also in the issue void-linux#2999 and

```
[    6.917367] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[    6.920611] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid
```
@edersohe
Copy link
Author

Ah, please also fix the commit message. The title should be the same as the PR title.

Done, thanks for you review.

@ericonr ericonr merged commit bffda1d into void-linux:master Feb 25, 2021
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Feb 28, 2021
* crda-4.14
* wireless-regdb-2020.12.20

fix error messages like

```
[    6.954196] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
[    6.954207] cfg80211: failed to load regulatory.db
```

registered also in the issue void-linux#2999 and

```
[    6.917367] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[    6.920611] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid
```
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants