Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcmanfm: update to 1.3.2. and adopt. #28605

Closed
wants to merge 1 commit into from

Conversation

uw2021
Copy link

@uw2021 uw2021 commented Feb 9, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Feb 10, 2021

Would be nice to update libfm and libfm-extra as well.

@uw2021
Copy link
Author

uw2021 commented Feb 10, 2021

Would be nice to update libfm and libfm-extra as well.

Done - #28619 and #28620.

@ericonr
Copy link
Member

ericonr commented Feb 10, 2021

Please do them in this PR. Especially libfm and libfm-extra should be in exactly the same PR, as mentioned in their templates.

@uw2021
Copy link
Author

uw2021 commented Feb 10, 2021

Please do them in this PR. Especially libfm and libfm-extra should be in exactly the same PR, as mentioned in their templates.

I saw that but had never pushed an update like that before, do I just force push those two template changes to this branch?

@ericonr
Copy link
Member

ericonr commented Feb 10, 2021

Yes, with a commit for each one. The PR will have 3 commits.

@ericonr
Copy link
Member

ericonr commented Feb 10, 2021

Yes, with a commit for each one. The PR will have 3 commits.

@uw2021 uw2021 closed this Feb 11, 2021
@uw2021 uw2021 deleted the pcmanfm-update branch February 11, 2021 18:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants