Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: remove rtkit dependency and update to 14.2 #28771

Merged
merged 2 commits into from Feb 16, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Feb 15, 2021

PulseAudio doesn't need rtkit available to work for basic usage, so
it's better to only pull it in when a user wants realtime (the error
messages should also be clear enough).

Since rtkit now pulls in a complex dependency in polkit, we can avoid
pulseaudio also pulling the whole thing in.

I have yet to test this throroughly. Basic functionality is fine.

@q66

@ericonr ericonr changed the title pulseaudio: remove rtkit dependency. pulseaudio: remove rtkit dependency and update to 14.2 Feb 15, 2021
@q66
Copy link
Contributor

q66 commented Feb 15, 2021

no, not really

this will just result in 1) people not knowing what to install when they need it 2) rtkit becoming an orphan and getting autoremoved on existing systems

you just shouldn't have added polkit dependency in rtkit in the first place

@fosslinux
Copy link
Contributor

fosslinux commented Feb 16, 2021

Why not, https://github.com/heftig/rtkit/blob/master/README#L226 says it is needed (is upstream just wrong about requirements for their own software (wouldn't be the first time lol))

hm, but https://github.com/heftig/rtkit/blob/c295fa849f52b487be6433e69e08b46251950399/meson.build#L21 says that it is optional.

@ericonr
Copy link
Member Author

ericonr commented Feb 16, 2021

@fosslinux it's optional only because they can use it to determine where to dump the polkit config file https://github.com/heftig/rtkit/blob/c295fa849f52b487be6433e69e08b46251950399/meson.build#L53 , otherwise they have a fallback. And this is at build time, not at runtime (you shouldn't check for runtime dependencies like that at build time, after all).

ericonr and others added 2 commits February 16, 2021 16:25
Add comments about elogind and unit tests.

Closes: void-linux#27973 [via git-merge-pr]

Co-authored-by: UsernameRandomlyGenerated <coredavid@tutanota.com>
@ericonr ericonr merged commit e97a09b into void-linux:master Feb 16, 2021
@ericonr ericonr deleted the pulse branch February 16, 2021 19:28
@fosslinux
Copy link
Contributor

Oh, duh, silly me! Yeah, ofc it wont detect for runtime at buildtime lol

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants