Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saml2aws: fix go_import_path. #28878

Merged
merged 1 commit into from Feb 21, 2021
Merged

saml2aws: fix go_import_path. #28878

merged 1 commit into from Feb 21, 2021

Conversation

ericonr
Copy link
Member

@ericonr ericonr commented Feb 19, 2021

@ScOut3R

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Copy link
Contributor

@ScOut3R ScOut3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ericonr, I think this was preventing me from updating saml2aws. :)

@ericonr
Copy link
Member Author

ericonr commented Feb 19, 2021

@ScOut3R it seems they hadn't changed the module path in the version we ship... Can you take the change and include it in your PR to update the package? Then I will close this PR.

@ericonr
Copy link
Member Author

ericonr commented Feb 21, 2021

@ScOut3R I've switched the PR to be an update, please test it out :)

srcpkgs/saml2aws/template Outdated Show resolved Hide resolved
@ericonr ericonr merged commit 6ca392e into void-linux:master Feb 21, 2021
@ericonr ericonr deleted the fixgo4 branch February 21, 2021 22:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants