Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-pytest-mock: update to 3.5.1 #28903

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

heliocat
Copy link
Contributor

Breaking changes:
drop deprecated mock alias to mocker
drop python 2.7 and 3.4 support

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Updating some low-hanging fruit, I noted any breaking changes as documented.

srcpkgs/python3-pytest-mock/template Outdated Show resolved Hide resolved
srcpkgs/python3-pytest-mock/template Outdated Show resolved Hide resolved
@ericonr
Copy link
Member

ericonr commented Feb 20, 2021

I'm running tests for package which use this one. So far python3-natsort, python3-aiohttp2 have failed

Also tox

@ericonr
Copy link
Member

ericonr commented Feb 20, 2021

All three also fail with old -mock, so I think we can stick with the update.

@heliocat
Copy link
Contributor Author

I just ran through all of the dependent packages. natsort and aiohttp2 both fail their tests at the same places and at the same rates. Tox passed both old and new tests with the skip section in the template.

Breaking changes:
drop deprecated mock alias to mocker
drop python 2.7 and 3.4 support
@ericonr ericonr merged commit 2c8f830 into void-linux:master Feb 22, 2021
@heliocat heliocat deleted the python3-pytest-mock branch February 24, 2021 17:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants