Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: update to 0.22.6. #28915

Closed
wants to merge 1 commit into from
Closed

mpd: update to 0.22.6. #28915

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked at the test failure for musl? It was present on 0.22.4 already, so no reason to hold the update on it, but would be nice to get fixed one way or another.

@@ -37,7 +37,7 @@ license="GPL-2.0-or-later"
homepage="https://www.musicpd.org/"
changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v${version}/NEWS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v${version}/NEWS"
changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/master/NEWS"

@tibequadorian
Copy link
Contributor

Have you looked at the test failure for musl? It was present on 0.22.4 already, so no reason to hold the update on it, but would be nice to get fixed one way or another.

I think it's because musl strptime does not support the %F field descriptor

@ericonr
Copy link
Member

ericonr commented Feb 25, 2021

Nice find! I will try to write up a patch.

@ericonr
Copy link
Member

ericonr commented Feb 25, 2021

Pull in MusicPlayerDaemon/MPD#1110

Pulling in MusicPlayerDaemon/MPD#1111 doesn't cost anything either :p

@tibequadorian tibequadorian mentioned this pull request Feb 25, 2021
3 tasks
@ghost ghost deleted the mpd0226 branch March 2, 2021 07:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants