Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: pipe-viewer-0.0.7 #29014

Merged
merged 1 commit into from
Feb 24, 2021
Merged

New package: pipe-viewer-0.0.7 #29014

merged 1 commit into from
Feb 24, 2021

Conversation

r-ricci
Copy link
Contributor

@r-ricci r-ricci commented Feb 23, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Feb 23, 2021

We already ship youtube-viewer, straw-viewer and a few others. Do you think this one is noticeably different?

@ericonr ericonr added the new-package This PR adds a new package label Feb 23, 2021
@r-ricci
Copy link
Contributor Author

r-ricci commented Feb 23, 2021

@ericonr see #29015

checksum=5e1211ec963aa2a187bcb0983227c5667e6c580bfc9de93dcb582388cc1baf22

pipe-viewer-gtk_package() {
depends="${sourcepkg}-${version}_${revision} perl-Gtk3 perl-File-ShareDir"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be sourcepkg>=

@ericonr
Copy link
Member

ericonr commented Feb 24, 2021

Interesting, thanks for the context!

Once straw-viewer is deprecated, do you think pipe-viewer could receive a meta package for it?

@r-ricci
Copy link
Contributor Author

r-ricci commented Feb 24, 2021

Yes, I could add a dummy subpackage to pipe-viewer.

@ericonr ericonr merged commit a28af9e into void-linux:master Feb 24, 2021
@r-ricci r-ricci deleted the pipe-viewer branch February 24, 2021 15:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants