Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dunst: update to 1.6.1 #29039

Merged
merged 1 commit into from Feb 27, 2021
Merged

dunst: update to 1.6.1 #29039

merged 1 commit into from Feb 27, 2021

Conversation

biopsin
Copy link
Contributor

@biopsin biopsin commented Feb 24, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Drop make_build_target defaults to all
Add wayland support (default force_wayland = false)

@biopsin
Copy link
Contributor Author

biopsin commented Feb 24, 2021

wtf

@folliehiyuki
Copy link
Contributor

Don't do git merge :) Do git pull --rebase from upstream branch instead

@folliehiyuki
Copy link
Contributor

Anyway dunst natively runs on Wayland is a huge deal for me. I was kinda waiting for this.
Will try it out when I finish digging the doc and updating my config.

@biopsin
Copy link
Contributor Author

biopsin commented Feb 25, 2021

@folliehiyuki You should diff your dunstrc with the one in /etc/dunst as there are some changes.
Any feedback is appriciated, as I don't run wayland.

@folliehiyuki
Copy link
Contributor

Seems to work natively on sway for me. xeyes doesn't see the notifications.
The new progress bar feature works ok too.
I only use notification for basic backlight / volume control, so my testing ability is limited :)

hostmakedepends="perl pkg-config"
makedepends="gtk+-devel libXScrnSaver-devel libXinerama-devel libXrandr-devel
libxdg-basedir-devel libnotify-devel"
libxdg-basedir-devel libnotify-devel wayland-devel wayland-protocols"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about 100% sure wayland-protocols isn't making any difference here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's being used to determine if Wayland should be built at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAYLAND=(0|1): Disable/Enable wayland support. (Default: 1 (enabled))

I think it always tries to build with Wayland.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package wayland-protocols was not found in the pkg-config search path.
Perhaps you should add the directory containing `wayland-protocols.pc'
to the PKG_CONFIG_PATH environment variable
No package 'wayland-protocols' found
Makefile:40: "Failed to query pkg-config for package 'wayland-protocols'!"

Yes enable build default, so you mean you would like wayland be put in a build_option_ ?

Drop make_build_target it defaults to all
Add wayland support (default force_wayland = false)
Drop binary files install it's now handled too

update
@biopsin
Copy link
Contributor Author

biopsin commented Feb 26, 2021

@ericonr template updated; when you have the time to take a peek, I'm in a limbo regarding the wayland-protocols comment, build stage complains if it's not pressent (see #29039 (comment)).

@ericonr
Copy link
Member

ericonr commented Feb 27, 2021

I don't think a build option is necessary, but it's simple enough. And some of their pkg-config invocations must require wayland protocols, despite it not being necessary. Thanks for checking :)

@ericonr ericonr merged commit 60ec8ac into void-linux:master Feb 27, 2021
@biopsin biopsin deleted the patch-1 branch February 27, 2021 11:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants