New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dunst: update to 1.6.1 #29039
dunst: update to 1.6.1 #29039
Conversation
wtf |
Don't do |
Anyway |
@folliehiyuki You should diff your dunstrc with the one in /etc/dunst as there are some changes. |
Seems to work natively on |
srcpkgs/dunst/template
Outdated
hostmakedepends="perl pkg-config" | ||
makedepends="gtk+-devel libXScrnSaver-devel libXinerama-devel libXrandr-devel | ||
libxdg-basedir-devel libnotify-devel" | ||
libxdg-basedir-devel libnotify-devel wayland-devel wayland-protocols" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm about 100% sure wayland-protocols
isn't making any difference here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it's being used to determine if Wayland should be built at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAYLAND=(0|1): Disable/Enable wayland support. (Default: 1 (enabled))
I think it always tries to build with Wayland.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package wayland-protocols was not found in the pkg-config search path.
Perhaps you should add the directory containing `wayland-protocols.pc'
to the PKG_CONFIG_PATH environment variable
No package 'wayland-protocols' found
Makefile:40: "Failed to query pkg-config for package 'wayland-protocols'!"
Yes enable build default, so you mean you would like wayland be put in a build_option_ ?
Drop make_build_target it defaults to all Add wayland support (default force_wayland = false) Drop binary files install it's now handled too update
@ericonr template updated; when you have the time to take a peek, I'm in a limbo regarding the wayland-protocols comment, build stage complains if it's not pressent (see #29039 (comment)). |
I don't think a build option is necessary, but it's simple enough. And some of their |
General
Have the results of the proposed changes been tested?
Drop make_build_target defaults to all
Add wayland support (default force_wayland = false)