Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musescore: update to 3.6.2. #29063

Merged
merged 1 commit into from Feb 28, 2021
Merged

musescore: update to 3.6.2. #29063

merged 1 commit into from Feb 28, 2021

Conversation

tibequadorian
Copy link
Contributor

Change maintainer (#29061)

I'll see if I can get cross builds working...

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@tibequadorian
Copy link
Contributor Author

Cross builds now work!

With qt5-webengine they only work with the patch I've included, only for little-endian build target and only if word size of host and target matches.
Luckily it's a really unnecessecary dependency on musescore, therefore I've disabled it by default. Patch is still there if someone wants to enable it.

Still needs testing because I've only tested it on x86_64-glibc.

@tibequadorian
Copy link
Contributor Author

Wanna take a look, @ericonr ? :D

@tibequadorian
Copy link
Contributor Author

tibequadorian commented Feb 27, 2021 •
edited

update: removed the qt5-webengine option (and patch) completely, there's no reason to keep it tbh

@tibequadorian tibequadorian changed the title [WIP] musescore: update to 3.6.2. musescore: update to 3.6.2. Feb 27, 2021
ericonr
ericonr reviewed Feb 27, 2021
View reviewed changes
Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in the commit message why the qtwebengine option isn't necessary?

srcpkgs/musescore/template
Comment on lines +23 to +24
${_soundfont_url}/MuseScore_General.sf3
${_soundfont_url}/MuseScore_General_License.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no versioned variants of this file? If upstream changes them, the template will just stop building :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so :/ These are the same that CMakeLists.txt uses to download ... at least they're checksummed now, remember #27451 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if upstream changes them, they would have to update too

@tibequadorian
Copy link
Contributor Author

Can you explain in the commit message why the qtwebengine option isn't necessary?

Yeah I mean it just provides a small bar in the start center that links to several youtube videos about the software... nothing anyone will even notice

musescore: update to 3.6.2.
a9f1534 
change maintainer
enable cross builds
add soundfont to distfiles
disable qtwebengine because its unportable and unnecessary as it just provides web content in the start center
@ericonr ericonr merged commit 453d9b4 into void-linux:master Feb 28, 2021
@tibequadorian tibequadorian deleted the musescore branch February 28, 2021 13:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericonr ericonr ericonr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tibequadorian @ericonr