Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] New package: fluent-bit-1.7.1 #29064

Closed
wants to merge 1 commit into from
Closed

[WIP] New package: fluent-bit-1.7.1 #29064

wants to merge 1 commit into from

Conversation

SimonAdameit
Copy link

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@SimonAdameit SimonAdameit changed the title New package: fluent-bit-1.7.1 [WIP] New package: fluent-bit-1.7.1 Feb 25, 2021
sgn
sgn reviewed Feb 26, 2021
View reviewed changes
srcpkgs/fluent-bit/template Outdated Show resolved Hide resolved
sgn
sgn reviewed Feb 26, 2021
View reviewed changes
srcpkgs/fluent-bit/template
configure_args+=" -DFLB_TRACE=Off"

# Enable Features
configure_args+=" -DFLB_JEMALLOC=On"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unbundle jemalloc please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And mbedtls, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other word, I would rm -rf lib in post_extract and fix their build system to use system libraries.

@ericonr ericonr added the new-package This PR adds a new package label Feb 26, 2021
@SimonAdameit
Copy link
Author

@sgn @ericonr Thanks for the reviews! I decided to not get this into void, due to the effort involved. I still applied and pushed the changes you suggested, except for the unbundling, which I won't perform now.

sgn pushed a commit to sgn/void-packages that referenced this pull request Feb 28, 2021
@SimonAdameit @sgn
New package: fluent-bit-1.7.1
7ec80e8 
Close: void-linux#29064
@sgn
Copy link
Member

sgn commented Feb 28, 2021

Hi, I spent my time to de-bundle most of libraries from fluent-bit.
If you want to try, here you're https://github.com/sgn/void-packages/tree/fluent-bit

If you can confirm it's good for you, I'll submit it to upstream.
There're some libraries that I didn't de-bundle because their developers also work on fluent-bit.

sgn pushed a commit to sgn/void-packages that referenced this pull request Mar 1, 2021
@SimonAdameit @sgn
New package: fluent-bit-1.7.1
b3d5da2 
Close: void-linux#29064
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sgn sgn sgn left review comments

Assignees
No one assigned
Labels
new-package This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimonAdameit @sgn @ericonr