New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quaternion: update to 0.0.95.beta5., libqmatrixclient: rename and update to libQuotient-0.6.6. #29082
Conversation
srcpkgs/removed-packages/template
Outdated
@@ -166,6 +166,7 @@ replaces=" | |||
libfcitx-qt-devel<=4.2.9.8_1 | |||
libgksu<=2.0.12_5 | |||
libglib-static<=2.58.3_5 | |||
libqmatrixclient<=0.5.3.2_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make people who have this package installed unable to update if XBPS is updated at the same time. I think this should be moved to a transitional dummy package, maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need transitional dummy. Just left it there and let users remove the orphan with xbps-remove -o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this shouldn't be here. We don't want a repeat of #28779
srcpkgs/Quaternion/template
Outdated
@@ -1,19 +1,21 @@ | |||
# Template file for 'Quaternion' | |||
pkgname=Quaternion | |||
version=0.0.9.4e | |||
version=0.0.95.beta4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move to beta? We prefer to stick with stable releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.0.9.4 is almost 2 years old
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.0.9.4f marked as "latest" is just two months, use it if being new is main reason to prefer unstable thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason to update to 0.0.9.4f since it has the same code as 0.0.9.4e (which is from April 2020). It is just a rebuild for windows to use newer Qt: https://github.com/quotient-im/Quaternion/releases/tag/0.0.9.4f
common/shlibs
Outdated
@@ -3924,3 +3923,4 @@ libsimavr.so.1 simavr-1.6_2 | |||
libsimavrparts.so.1 simavr-1.6_2 | |||
libsword-1.8.1.so libsword-1.8.1_6 | |||
libtree-sitter.so.0 tree-sitter-0.18.2_1 | |||
libQuotient.so.0.6 libQuotient-0.6.5_1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put this line below the old one, otherwise you can end up having to rebase the PR constantly due to new packages.
Could you please rebase the PR? |
@ericonr done |
The package was only used for Quaternion<=0.0.9.4, but since the newer versions use an API under a new name -- libQuotient, it can be removed.
General
Have the results of the proposed changes been tested?
Does it build and run successfully?
(Please choose at least one native build and, if supported, at least one cross build. More are better.)