Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base-files: initialise empty etc/modules-load.d folder #29099

Merged
merged 1 commit into from Mar 1, 2021

Conversation

NeelChotai
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Feb 28, 2021

Please rebase, and hold this change for a bit. I want to see if we can ship directories in XBPS.

@fosslinux
Copy link
Contributor

Is there a compelling reason for this? (I do not see one). It's very trivial to mkdir /etc/modules-load.d if you want that. This adds confusion to users, IMO, but that's just me. (Either way I don't really mind, though).

@NeelChotai
Copy link
Contributor Author

NeelChotai commented Mar 1, 2021

Is there a compelling reason for this? (I do not see one). It's very trivial to mkdir /etc/modules-load.d if you want that. This adds confusion to users, IMO, but that's just me. (Either way I don't really mind, though).

If an empty /etc/modprobe.d folder is initialised, it stands to reason that an empty /etc/modules-load.d should also be initialised.

@fosslinux
Copy link
Contributor

Hm, ok, that's fair.

@ericonr
Copy link
Member

ericonr commented Mar 1, 2021

To avoid holding this up indefinitely, I'm pushing as is. Doing a bigger fix can come later.

@ericonr ericonr merged commit 3c27182 into void-linux:master Mar 1, 2021
@NeelChotai NeelChotai deleted the base-files-modules-load branch March 2, 2021 14:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants