Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isl: update to 0.23 (with cloog and soname) #29104

Merged
merged 2 commits into from Mar 12, 2021
Merged

Conversation

dkwo
Copy link
Contributor

@dkwo dkwo commented Feb 27, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@dkwo
Copy link
Contributor Author

dkwo commented Feb 27, 2021

See also #24424
This time I only revbump cloog.

srcpkgs/isl/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented Feb 28, 2021

@pullmoll @tornaria how does it look now?

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're updating two packages here, you should have a commit for each.

srcpkgs/isl/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented Feb 28, 2021

@ericonr Thanks, I think I fixed it.

@tornaria
Copy link
Contributor

Looks good to me, I compiled sagemath-9.2 using this without any issue.

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isl commit message should mention that it's fixing the license and homepage.

srcpkgs/isl/template Outdated Show resolved Hide resolved
@dkwo
Copy link
Contributor Author

dkwo commented Mar 11, 2021

@ericonr is the cloog repo fine or should I revert it back to the previous (obsolete) one?

@ericonr
Copy link
Member

ericonr commented Mar 11, 2021

Ok, I think the cloog commit should mention that it's changing the distfiles origin, but otherwise LGTM. Just fix the commit message and we are good.

@dkwo
Copy link
Contributor Author

dkwo commented Mar 12, 2021

@ericonr Done.

@ericonr ericonr merged commit d85931a into void-linux:master Mar 12, 2021
@dkwo dkwo deleted the isl branch March 22, 2021 09:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants