Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwacom: update to 1.9. #29127

Merged
merged 1 commit into from Mar 1, 2021
Merged

libwacom: update to 1.9. #29127

merged 1 commit into from Mar 1, 2021

Conversation

skmpz
Copy link
Contributor

@skmpz skmpz commented Feb 28, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Feb 28, 2021

Alternatively, you can do -Dtests=disabled (https://github.com/linuxwacom/libwacom/blob/master/meson_options.txt#L9) when $XBPS_CHECK_PKGS isn't set.

@skmpz
Copy link
Contributor Author

skmpz commented Mar 1, 2021

Thanks for the info. What if we have

hostmakedepends="pkg-config"
checkdepends="python3-pytest python3-libevdev python3-pyudev"

and

if [ -z "${XBPS_CHECK_PKGS}" ]; then
	configure_args+=" -Dtests=disabled"
fi

Then if we add the checks in cross compilation

./xbps-src -Q pkg -a aarch64 -f libwacom

This will fail right? Isn't that a valid thing? Or we can consider -Q will not be used when cross compiling?

@ericonr
Copy link
Member

ericonr commented Mar 1, 2021

I think XBPS_CHECK_PKGS is unset when cross compiling, no matter the options passed... Not sure though. You can probably add those options and try. For the record, neither CI nor the builders use -Q for cross builders.

@skmpz
Copy link
Contributor Author

skmpz commented Mar 1, 2021

Well, it seems that XBPS_CHECK_PKGS is set when run with

./xbps-src -Q pkg -a aarch64 -f libwacom

But since CI/builders don't use -Q for cross builders I guess it's fine to go with the proposed change.

@ericonr ericonr merged commit 54ab8a1 into void-linux:master Mar 1, 2021
@skmpz skmpz deleted the libwacom-1.9 branch March 25, 2021 08:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants