Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: calls + deps (callaudiod + feedbackd) #29138

Closed
wants to merge 3 commits into from

Conversation

jcgruenhage
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@jcgruenhage jcgruenhage force-pushed the calls-0.3.1_1 branch 2 times, most recently from 68a64d4 to 4cd8cee Compare February 28, 2021 22:46
@ericonr ericonr added the new-package This PR adds a new package label Mar 8, 2021
@github-actions
Copy link

github-actions bot commented May 5, 2022

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 5, 2022
@Piraty
Copy link
Member

Piraty commented May 7, 2022

@jcgruenhage what's missing here ? (besides an environment to use this on to acually make phone calls ;) )
I assume @JamiKettunen is interested as well?

@JamiKettunen
Copy link
Contributor

JamiKettunen commented May 7, 2022

@Piraty Yes I'd be interested, I've actually already got these as a part of my phone dev packages (gnome-calls, ̣callaudiod, feedbackd) but haven't unfortunately been able to test them yet on my Qualcomm hardware due to no working call audio routing from the modem :(

@github-actions github-actions bot removed the Stale label May 8, 2022
@jcgruenhage
Copy link
Contributor Author

The modem shouldn't be the problem on my phone, calling was working just fine on pmOS. How much would I need to get going for this working on Void, any idea @JamiKettunen? Would gnome-calls, callaudiod, feedbackd and ModemManager already be enough?

@JamiKettunen
Copy link
Contributor

JamiKettunen commented May 10, 2022

@jcgruenhage I unfortunately have no idea how the PinePhone cellular stack typically works, I'll explore it more in-depth after getting my PinePhone hopefully soon. However I've seen eg25-manager mentioned in Sxmo scripts for example so that may be needed on top of what you mentioned already.

@Piraty
Copy link
Member

Piraty commented May 11, 2022

you may get calls working without eg25-manager but it will probably require fiddling with audio settings via at commands

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Aug 10, 2022
@jcgruenhage
Copy link
Contributor Author

Well, sort-of stale, but I still plan to continue on it.

@github-actions github-actions bot removed the Stale label Aug 18, 2022
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Nov 17, 2022
@Piraty Piraty removed the Stale label Nov 18, 2022
@Piraty
Copy link
Member

Piraty commented Nov 18, 2022

i'll be happy to merge once you rebased and possibly updated to latest, to bring this forward and enable broader integration of mobile phone stack

@jcgruenhage
Copy link
Contributor Author

I'll try to take a look at this later today when I'm back at home and have access to my pinephone again. Would it make sense to merge those applications already even if the remaining stack for making calls isn't necessarily all there and tested already?

@jcgruenhage
Copy link
Contributor Author

not quite sure what's up here but void doesn't boot on my pinephone right now, but postmarketos does.. I'll have to check again another day when I have a bit more time to investigate..

@jcgruenhage
Copy link
Contributor Author

Getting better and better: Seems that void didn't boot because it was on the sdcard, and the phone was deeply discharged enough that the additional power draw of the sdcard means it couldn't boot. Now that the phone is charged again, void boots just fine. Next hurdle now: Sway doesn't want to launch. I'd assume it's related to the kernel being ancient. I'll look into this again once Linux 6.1.0 is released, because a few new things for the pinephone are in the current release candidates.

@jcgruenhage
Copy link
Contributor Author

So, another two months have gone by, and I have a small-ish update. #41654 brings in kernel 6.1.3, which brings in a bunch of improvements, including finally having the keyboard case working. I still need to grab an adapter to connect a proper keyboard to it for initial setup, which I don't have with me right now, but I'll try to make a little more progress here again.

@JamiKettunen
Copy link
Contributor

JamiKettunen commented Jan 14, 2023

@jcgruenhage if you don't mind I can submit updated packages which I've confirmed work (minus call audio since I don't have that hooked up in DTS) on my OnePlus 5 phone running a mainline Linux kernel :)

About to start maintaining ModemManager stack too along with some updates there, stay tuned for that PR ^^

@jcgruenhage
Copy link
Contributor Author

I absolutely don't mind, feel free to take over ^^

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 16, 2023
@github-actions github-actions bot closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants