New package: Shortwave-2.0.1

[oynqr]

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

• I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
• I generally don't use the affected packages but briefly tested this PR

I did not find what causes the x86_64-musl builds to fail, any help with that would be appreciated.
Closes #28886

[MPC7500]

Hello,

I am not familiar with the process. So the question, when will Shortwave merge with this repository?

In the meantime, Shortwave 2.0.1 has also been released.

[paper42]

2.0.0+ will need newer rust than what is in the repositories right now, so an update will need to wait for that (#30259)

[oynqr]

@MPC7500 I'm not quite sure what prevented this PR from being merged.
Although thanks for reminding me of the new releases, I didn't even notice them.

[oynqr]

@paper42 The README.md says that the minimum is 1.48, I'm just gonna try and see I suppose.

[paper42]

I think they are using const generics which are new in 1.51 and they are using GTK4 with libadwaita which is not packaged (because they didn't tag a release yet)

[MPC7500]

Thanks to all for the feedback!
Then I will be a little patient.
And to all VoidLinux maintainer: Great work, I love it!

[paper42]

@oynqr new rust is in the repositories, could you try updating this PR? We can not update to 2.0, because libadwaita still doesn't have a stable release.

[oynqr]

Can't update this until next wednesday, but I suppose it's not that urgent.

[oynqr]

Updated all dependencies since there were some vulnerabilities, no idea why CI randomly fails to download crates though

[ericonr]

Updated all dependencies since there were some vulnerabilities, no idea why CI randomly fails to download crates though

It's an upstream bug, it's been happening for a while now.

[ericonr]

We can not update to 2.0, because libadwaita still doesn't have a stable release.

I'd rather have an unstable release than merge the new package with such an old version... Especially with

Updated all dependencies since there were some vulnerabilities, no idea why CI randomly fails to download crates though

That's a 3k line patch that we shouldn't need (I think?) with the latest release.

[paper42]

We can not update to 2.0, because libadwaita still doesn't have a stable release.

I'd rather have an unstable release than merge the new package with such an old version... Especially with

At this point I agree, many packages are starting to require it. I will work on the vala and libadwaita PRs during the weekend.

[oynqr]

I have a working build of 2.0.1 using the libadwaita commit from @paper42, it's on my shortwave2 branch for anyone interested.

[paper42]

I have a working build of 2.0.1 using the libadwaita commit from @paper42, it's on my shortwave2 branch for anyone interested.

libadwaita is now merged, you can update this PR

[MPC7500]

Thanks to everyone for the effort.
This means that the following requests can be closed?

#20832
#27873
#28886

[ericonr]

@MPC7500 thanks, I closed the raddiu issue, will leave yours open to be closed automatically when this is merged.

#27873 I will rebase and merge once this is merged.

[oynqr]

I am really not impressed with this new version, it doesn't respect any of the global "prefer dark theme" options I throw at it, doesn't play a lot of streams when using pipewire, there are random crashes related to libadwaita and fonts are wonky.

The crashes don't seem to happen with the flatpak version, so I'm gonna have to look into that.

[paper42]

otherwise, it's looking great

[paper42]

why do we need sqlite-devel here? rust also shouldn't be necessary when we have cargo

[oynqr]

migrations_macros needs a host sqlite-devel for some reason when cross building

[paper42]

I think you wanted to push only one commit.

[paper42]

it doesn't respect any of the global "prefer dark theme" options I throw at it

That's probably because you are setting a GTK3 dark theme variant, afaik GTK4 doesn't have the concept of a theme variants, so you need to set a dark theme (and GTK4 settings are separate from GTK3, so GTK3 settings won't work).

doesn't play a lot of streams when using pipewire

It seems like we are hitting https://gitlab.gnome.org/World/Shortwave/-/issues/576 and https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1210

there are random crashes related to libadwaita

I also had a few crashes, I have RUST_BACKTRACE=1 set right now, so I will see what's going on. I don't think libadwaita is to blame, maybe the rust bindings?

fonts are wonky

Probably something with not having the correct fonts configured for GTK4, my fonts are fine.

[paper42]

there are random crashes related to libadwaita

I also had a few crashes, I have RUST_BACKTRACE=1 set right now, so I will see what's going on. I don't think libadwaita is to blame, maybe the rust bindings?

So we have a problem - Shortwave 2.0.1 was written before the first libadwaita release, so it depends on behavior that is changed in v1 which makes it crash. I don't think we should downgrade libadwaita for this, we should wait for Shortwave to fix this. The flatpak version works, because it packages a specific libadwaita version.

Could you try if building from their master branch fixes it? If yes, we could maybe ask for a 2.0.2 release or make an exception and package a specific commit? @ericonr

https://gitlab.gnome.org/World/Shortwave/-/issues/586

[MPC7500]

With the latest version of libadwaita Shortwave is stable. But you need now also libshumate which is alpha.
https://gitlab.gnome.org/GNOME/libshumate

[oynqr]

I am no longer interested in packaging this, as I neither use gnome itself nor any apps from its ecosystem anymore. To anyone trying to package this themselves, feel free to use this template as a base.