monero-gui: fix cross. #29266
Merged
monero-gui: fix cross. #29266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fosslinux
force-pushed
the
monero-gui-fix
branch
from
3b80745
to
ae463ea
Compare
We moved to ninja cmake generator so generate_translation_headers was not being generated properly as a makefile. Moving to ninja for the building command solves this issue.
fosslinux
force-pushed
the
monero-gui-fix
branch
from
ae463ea
to
94221dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream had moved to ninja so generate_translation_headers was not
being generated properly in the makefiles. Moving to ninja for the
building command solves this issue.
General
Have the results of the proposed changes been tested?