Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-style/cmake: set CMAKE_BUILD_TYPE to None #29459

Merged
merged 62 commits into from Apr 3, 2021
Merged

build-style/cmake: set CMAKE_BUILD_TYPE to None #29459

merged 62 commits into from Apr 3, 2021

Conversation

sgn
Copy link
Member

@sgn sgn commented Mar 14, 2021 •
edited

  • I'm going to build all packages with build_style=cmake and fix them one by one before merging this in.

[ci skip]

@sgn sgn force-pushed the cmake-build-type-to-None branch 3 times, most recently from a3a2d1f to 8f29b89 Compare March 21, 2021 09:45
@sgn sgn requested review from Johnnynator and Piraty March 21, 2021 09:46
@sgn sgn changed the title [WIP] build-style/cmake: set CMAKE_BUILD_TYPE to None build-style/cmake: set CMAKE_BUILD_TYPE to None Mar 21, 2021
@sgn
Copy link
Member Author

sgn commented Mar 21, 2021 •
edited

Below changes will be submited separately:

sgn
sgn commented Mar 21, 2021
View reviewed changes
srcpkgs/embree/template
@@ -4,6 +4,7 @@ version=2.17.7
revision=2
archs="x86_64"
build_style=cmake
configure_args="-DTBB_ROOT=/usr -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thypon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it derived from archlinux package.

It should be defined this way now '-DEMBREE_MAX_ISA="AVX512SKX"'

@sgn sgn requested a review from pullmoll March 21, 2021 09:51
@thypon
Copy link
Member

thypon commented Mar 21, 2021

What's the reason for switching from release to none?

@sgn
Copy link
Member Author

sgn commented Mar 21, 2021

What's the reason for switching from release to none?

Release force -O3

Piraty
Piraty reviewed Mar 23, 2021
View reviewed changes
srcpkgs/eigen/template Outdated
@@ -3,6 +3,8 @@ pkgname=eigen
version=3.3.9
revision=1
build_style=cmake
# This is header only library, don't waste time to patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might make a good commit message, but not an in-source comment

@sgn sgn force-pushed the cmake-build-type-to-None branch 2 times, most recently from a17e78e to a6de9ca Compare March 26, 2021 02:10
@sgn
Copy link
Member Author

sgn commented Mar 26, 2021

Question: Should we add -DNDEBUG to CFLAGS and CXXFLAGS?

@ericonr
Copy link
Member

ericonr commented Mar 26, 2021

I would rather not.

@ericonr
Copy link
Member

ericonr commented Mar 26, 2021

Hmmm, unless CMake release mode adds it... Then I guess yes... This complicated.

@sgn
Copy link
Member Author

sgn commented Mar 26, 2021

Hmmm, unless CMake release mode adds it... Then I guess yes... This complicated.

Yes, -DNDEBUG added in Release MinSizeRel and RelWithDebInfo.

@sgn sgn force-pushed the cmake-build-type-to-None branch 2 times, most recently from b03e1da to 77a508f Compare March 27, 2021 08:23
@sgn
Copy link
Member Author

sgn commented Mar 27, 2021

rspamd vendored too much dependencies. I gave up on it.

@sgn sgn force-pushed the cmake-build-type-to-None branch from b79bc64 to 104d046 Compare March 27, 2021 12:30
@sgn
Copy link
Member Author

sgn commented Mar 27, 2021

Most patching are done.
Package that adds -O2 and -g are ignored.

  • rspamd, yabause-gtk, yoshimi, zbackup, zig, zulucrypt adds -O3 but wasn't patched.

Would appreciate review from team.

@sgn sgn force-pushed the cmake-build-type-to-None branch from d95105d to b7f3310 Compare March 28, 2021 03:53
@sgn
Copy link
Member Author

sgn commented Mar 28, 2021

@void-linux/pkg-committers please have a look. I expect to push this out next weekend if no major change required.

@sgn sgn force-pushed the cmake-build-type-to-None branch 2 times, most recently from 08e63d5 to 4dff671 Compare March 29, 2021 15:30
@sgn sgn mentioned this pull request Apr 1, 2021
Merged
@sgn sgn force-pushed the cmake-build-type-to-None branch from 4dff671 to 3ee4c25 Compare April 3, 2021 03:00
sgn added 26 commits April 3, 2021 10:13
@sgn
cura-engine: ignore -O3
3f6198c
@sgn
dislocker: remove -O1
3e0728c
@sgn
freeorion: remove -O3
03adf7c
@sgn
cglm: fix build flags
13a02ba
@sgn
glyr: don't force Release build
5ad300f
@sgn
hugin: remove -O3
09487de
@sgn
ledger: don't overwrite CMAKE_BUILD_TYPE
981574a
@sgn
libmygpo-qt: remove -ggdb3
dfdd7c8
@sgn
libogre: don't build vendored libraries
7ff3ebc
@sgn
libopenglrecorder: remove -O3
44eb48c
@sgn
libvidstab: remove -O3
d56662e
@sgn
openlierox: don't overwrote CMAKE_BUILD_TYPE
34ea9f0
@sgn
opensonic: don't overwrite CMAKE_BUILD_TYPE
92b7a14
@sgn
rocksdb: don't overwrite CMAKE_BUILD_TYPE
12b8026
@sgn
seexpr-krita: don't overwrite CMAKE_BUILD_TYPE
17f0347
@sgn
speed-dreams: hardening
e2b0cc6
@sgn
traverso: hardening
e2f8037
@sgn
xstarter: hardening
bb3a94e
@sgn
yabause-gtk: ignore -O3
c48f788
@sgn
ympd: hardening
84b80b4
@sgn
z80ex: hardening
8743de2
@sgn
scribus: don't overwrite cmake-build-type
43c0677
@sgn
yoshimi: cleanup, don't overwrite CMAKE_BUILD_TYPE
9834775
@sgn
zulucrypt: remove -O3
d342ec4
@sgn
zbackup: don't overwrite CMAKE_BUILD_TYPE
8048e39
@sgn
rofs-filtered: hardening
2376856
@sgn sgn force-pushed the cmake-build-type-to-None branch from 3ee4c25 to 2376856 Compare April 3, 2021 03:13
@sgn sgn merged commit 2376856 into void-linux:master Apr 3, 2021
@sgn sgn deleted the cmake-build-type-to-None branch April 9, 2021 00:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thypon thypon thypon left review comments

@Piraty Piraty Piraty approved these changes

@Johnnynator Johnnynator Awaiting requested review from Johnnynator

@pullmoll pullmoll Awaiting requested review from pullmoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgn @thypon @ericonr @Piraty