Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulseEffects5 #29638

Closed
wants to merge 2 commits into from
Closed

PulseEffects5 #29638

wants to merge 2 commits into from

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Mar 20, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

PulseEffects 5 only supports PipeWire, so I made a new package pulseeffects-legacy which will stay on the PulseEffects 4. This approach is similar to what other distributions have done. I also added an install message to pulseeffects to let users know about this change.

related issue: #29006

@ericonr
Copy link
Member

ericonr commented Mar 21, 2021

This looks like a reasonable path forward.

@ericonr
Copy link
Member

ericonr commented Mar 22, 2021

Could you please add an update file to the legacy package? That way we can pick up any security updates, if they happen (I believe the dev said they could do security releases).

@paper42 paper42 force-pushed the pulseeffects5 branch 2 times, most recently from b3e1d8f to 3edff45 Compare March 22, 2021 21:56
@paper42
Copy link
Member Author

paper42 commented Mar 22, 2021

thanks, I also made pulseeffects-legacy conflict with pulseeffects

@ArchB1W
Copy link

ArchB1W commented Apr 3, 2021

It looks like pulseeffects5 won't launch without gstreamer1-pipewire. So that should probably be added as a dependency.

@ericonr
Copy link
Member

ericonr commented Apr 4, 2021

@GameWizard5000 thanks for the find. Should be good to merge once that's fixed.

@ericonr
Copy link
Member

ericonr commented Apr 4, 2021

@paper42 if you could mention in the commit for legacy that it's basically a copy of "old "pulseeffects, I think that'd be nice,

pulseeffects-legacy is a version of pulseeffects before 5.0.0 which still supports pulseaudio
@paper42
Copy link
Member Author

paper42 commented Apr 10, 2021

@ericonr @GameWizard5000 thank you both for your finds, they should be fixed now. I also reworded INSTALL.msg a bit, so hopefully it's a bit better now.

@ericonr ericonr closed this in f7d35e7 Apr 11, 2021
adbrown101 pushed a commit to adbrown101/void-packages that referenced this pull request Apr 12, 2021
Veganizer pushed a commit to Veganizer/void-packages that referenced this pull request Apr 13, 2021
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Apr 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
@paper42 paper42 deleted the pulseeffects5 branch April 8, 2022 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants