Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarpaulin: update to 0.17.0. #29688

Closed

Conversation

jcgruenhage
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Mar 22, 2021

Tests working on 32bit but failing on 64bit seems rather unexpected.

@jcgruenhage
Copy link
Contributor Author

yeah.. The thing is, I built the package and it works as expected locally. When I check out the release in a git repo and run the tests on my workstation with cargo directly, I get similar failures, so this is not really an issue with the packaging I think? Not sure what to do about this.

@ericonr
Copy link
Member

ericonr commented Mar 22, 2021

Take a look if upstream has issue reports about the failures, or how their CI runs tests :D

@jcgruenhage
Copy link
Contributor Author

Good call on checking their CI.. I had checked their docs and not found anything, but from their CI, it seems like they require the tests to run single-threaded, which we can pass in via make_check_args. I'm running the tests locally rn, if it works I'll push it once they're done.

@jcgruenhage
Copy link
Contributor Author

Okay, now this build timed out? This doesn't make much sense to me, it worked fine locally.

@ericonr ericonr closed this in b82280d Apr 4, 2021
hazayan pushed a commit to hazayan/void-packages that referenced this pull request Apr 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
@jcgruenhage jcgruenhage deleted the tarpaulin-0.17.0_1 branch August 9, 2022 19:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants