Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: update to 2.68.0 #29689

Closed

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Mar 22, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Mar 22, 2021

This one introduces some relevant new APIs, so I would increase the common/shlibs requirement.

@ericonr
Copy link
Member

ericonr commented Mar 22, 2021

If you want to make a separate PR for 2.66.8, we can merge that first. 2.68.0 is a bigger release.

@paper42
Copy link
Member Author

paper42 commented Mar 22, 2021

I would prefer to work on this PR, but if someone else updates the package to 2.66.8, I can just rebase this. This update will be neccesary for Gnome 40.

@paper42 paper42 force-pushed the 0001-glib-update-to-2.68.0.patch branch 2 times, most recently from 802018d to 65de1e8 Compare March 23, 2021 22:33
@paper42 paper42 force-pushed the 0001-glib-update-to-2.68.0.patch branch from 65de1e8 to 7ae990b Compare March 28, 2021 20:46
@paper42
Copy link
Member Author

paper42 commented Mar 28, 2021

I ran tests on my computer without patching them out and they all passed in a glibc and musl masterdir. I think I might be doing something wrong, because some of the tests are known to fail on musl.

@oreo639 oreo639 mentioned this pull request Apr 2, 2021
8 tasks
'mutex' : {},
'node' : {},
'once' : {},
- 'option-context' : {},
'option-argv0' : {},
'overflow' : {},
'overflow-fallback' : {
--
2.31.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of this tests can be fixed by adding python3-pytest to checkdepends.

@Gottox Gottox mentioned this pull request Apr 4, 2021
29 tasks
@ericonr
Copy link
Member

ericonr commented Apr 4, 2021

I ran tests on my computer without patching them out and they all passed in a glibc and musl masterdir. I think I might be doing something wrong, because some of the tests are known to fail on musl.

I think so; how are you running them? I usually do xbulk -Q glib.

@ericonr
Copy link
Member

ericonr commented Apr 4, 2021

I think we should include this patch: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2010 , it was a 2.68 regression.

@paper42
Copy link
Member Author

paper42 commented Apr 4, 2021

@Gottox do you want to take over this PR?

@Gottox
Copy link
Member

Gottox commented Apr 5, 2021

@paper42 Thanks, I cherry picked this commit. 👍

@Gottox Gottox closed this Apr 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
@paper42 paper42 deleted the 0001-glib-update-to-2.68.0.patch branch April 8, 2022 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants