Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

void-updates: update to 20210324. #29717

Closed
wants to merge 1 commit into from
Closed

void-updates: update to 20210324. #29717

wants to merge 1 commit into from

Conversation

42LoCo42
Copy link

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@Johnnynator
Copy link
Member

Why do you want to change this to something totally unrelated? Besides scripts like that do not meet the quality requirement for new packages.

@42LoCo42
Copy link
Author

I found the old void-updates script to be quite slow and computationally intensive.
Thus I rewrote it with the goal of maximum speed and stability.
My version is significantly faster, taking only a few seconds to generate a list of packages to upgrade.
If that is not the goal of the original script, I'm sorry that I have wasted your time with this PR.
Apart from that, I don't really see why my script would not meet the quality requirements.
Shellcheck reports no warnings and all functions have descriptive names, which eases debugging.

@ericonr
Copy link
Member

ericonr commented Mar 24, 2021

@42LoCo42 please make a PR to the proper repository and it can be discussed there. Changing upstream of the script is not really an option.

@Johnnynator
Copy link
Member

I think you didn't quite catch what the old script did. It checked upstream if the version in a template was old. You script checks if a package in your local binary repo is older than the template.

For what you do, take a look at xbps-checkvers (it is probably even faster than your script)

@ericonr
Copy link
Member

ericonr commented Mar 24, 2021

That is, PR your code changes to void-updates repository.

@42LoCo42
Copy link
Author

Thank you all for enlightening me on this matter!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants