python3-pgzero: update to 1.2.1. #29720
Conversation
srcpkgs/python3-pgzero/template
Outdated
| do_check() { | ||
| : requires video device | ||
| } |
There was a problem hiding this comment.
make_check=no or maybe extended instead of defining an empty function, but you can probably try wrapping the test command in xvfb-run?
There was a problem hiding this comment.
Ah, Ok. I didn't know about make_check and have updated the template to use that. I tried to use xvfb-run, but I could not get that to work.
srcpkgs/python3-pgzero/template
Outdated
| hostmakedepends="python3-setuptools" | ||
| depends="python3-setuptools python3-pygame python3-numpy" | ||
| depends="python3-setuptools python3-pygame>=2.0.0 python3-numpy" |
There was a problem hiding this comment.
I don't think we need to specify the version here, since it will come in a single update to the dependency chain.
There was a problem hiding this comment.
Ok, I have removed this.
srcpkgs/python3-pgzero/template
Outdated
| short_desc="Zero-boilerplate games programming framework based on Pygame (Python3)" | ||
| maintainer="Peter Bui <pbui@github.bx612.space>" | ||
| license="LGPL-3.0-or-later" | ||
| homepage="https://pygame-zero.readthedocs.io/en/stable/" | ||
| distfiles="${PYPI_SITE}/p/pgzero/pgzero-${version}.tar.gz" | ||
| checksum=91e641d545c6235a24719dea0fd83c8429e92a8b5ab1756bef145128e8db9017 | ||
| checksum=8cadc020f028cbac3e0cbd3bb9311a1c045f1deedac7917ff433f986c38e6106 | ||
| make_check=no |
There was a problem hiding this comment.
Do leave a comment as to why tests are disabled :)
| pre_build() { | ||
| # Remove the C source to re-cythonize, which avoids some API changes | ||
| rm src_c/pypm.c src_c/_sdl2/{sdl2,audio,video}.c | ||
| } |
There was a problem hiding this comment.
Did they stop shipping these files or did re-generation stop being necessary?
There was a problem hiding this comment.
I believe the re-generation is no longer necessary. I checked the ArchLinux package and they do not have this there and it appears to work without this.
Closes: void-linux#29720 [via git-merge-pr]
Also update related dependency python3-pygame to 2.0.0. This now uses SDL2 rather than SDL. The only package that depends on python3-pygame appears to be pysolfc and I have tested that it still runs with this update to python3-pygame.
General
Have the results of the proposed changes been tested?