Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: opensnitch-1.3.6 #29849

Closed
wants to merge 1 commit into from
Closed

New package: opensnitch-1.3.6 #29849

wants to merge 1 commit into from

Conversation

anubhavkini
Copy link
Contributor

@anubhavkini anubhavkini commented Mar 29, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

closes #28819

@folliehiyuki
Copy link
Contributor

Should closes #28819

@ericonr ericonr added the new-package This PR adds a new package label Mar 29, 2021
@ericonr
Copy link
Member

ericonr commented Mar 29, 2021

Should be one New package: pkgname-version commit per package.

@Duncaen
Copy link
Member

Duncaen commented Mar 29, 2021

Is there a reason to split this into a meta package and a d package?
IMHO should should just be opensnitch containing the daemon and maybe a subpackage for the ui.

@anubhavkini
Copy link
Contributor Author

anubhavkini commented Mar 29, 2021

Is there a reason to split this into a meta package and a d package?

It was easier since opensnitchd uses the go build-style and opensnitch-ui uses python3-module build-style.

@anubhavkini
Copy link
Contributor Author

IMHO should should just be opensnitch containing the daemon and maybe a subpackage for the ui.

Can subpackages have a different build-style from the source package?

@Duncaen
Copy link
Member

Duncaen commented Mar 29, 2021

No subpackages just move files from the main package, you would have to build it in the main package so you would have to do your own do_configure/do_build/do_install to build both and then move files into sub packages.

@anubhavkini
Copy link
Contributor Author

Alright, I'll try that.

@ericonr
Copy link
Member

ericonr commented Mar 29, 2021

@Duncaen maybe make one package for daemon and one for UI, to avoid having to duplicate most of the build logic? And make the daemon depend on the UI, if that makes sense.

I agree on the meta not being necessary. It's unfortunate that they use the same distfiles for both... If we go the route of separate packages, I'd add a comment to each template about keeping in sync with the other.

@Duncaen
Copy link
Member

Duncaen commented Mar 29, 2021

The separation between ui and daemon doesn't make a lot of sense and becomes cyclic if we add the dependencies on each other, which would be the only correct way to ensure that both are installed and at the same version.

@anubhavkini anubhavkini changed the title New package: opensnitch-1.3.6 [WIP] New package: opensnitch-1.3.6 Mar 29, 2021
@anubhavkini anubhavkini changed the title [WIP] New package: opensnitch-1.3.6 New package: opensnitch-1.3.6 May 12, 2021
@anubhavkini
Copy link
Contributor Author

Finally got it to work

@anubhavkini
Copy link
Contributor Author

@ericonr does this look okay?

@ericonr
Copy link
Member

ericonr commented May 13, 2021

Sorry, I won't be able to review this soon.

@anubhavkini anubhavkini closed this Jun 3, 2021
@cinerea0 cinerea0 mentioned this pull request Aug 28, 2021
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: OpenSnitch
4 participants