Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: pmacct-1.7.6 #29853

Closed
wants to merge 1 commit into from
Closed

Conversation

ailiop-git
Copy link
Contributor

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr ericonr added the new-package This PR adds a new package label Mar 29, 2021
version=1.7.6
revision=1
build_style=gnu-configure
hostmakedepends="libpcap-devel autoconf automake libtool"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it need autoconf and automake, given that it's using the gnu-configure build style, so at least configure has already been generated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it need autoconf and automake, given that it's using the gnu-configure build style, so at least configure has already been generated?

Because the makefile under src/external_libs calls autogen.sh for libcdada among other things, and generally expects to generate everything for libcdada. Indeed this shouldn't be necessary as configure is already generated for it, but I didn't want to mess with the makefile right now, this needs to be properly fixed in the upstream project.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 15, 2022
@github-actions github-actions bot closed this May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants