Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: mpvpaper-1.1 #29962

Closed
wants to merge 1 commit into from

Conversation

folliehiyuki
Copy link
Contributor

@folliehiyuki folliehiyuki commented Apr 2, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Apr 2, 2021

Needs wayland-devel in host.

I'd like to wait for a wlroots release before merging this, to see how they work with it.

@ericonr ericonr added the new-package This PR adds a new package label Apr 2, 2021
@folliehiyuki
Copy link
Contributor Author

I tested briefly on hikari, river, sway and wayfire.
Seems to work fine with wlroots-0.13.0.

@folliehiyuki
Copy link
Contributor Author

@ericonr good to merge?

Comment on lines 7 to 8
makedepends="mpv-devel wlroots-devel"
depends="mpv wlroots"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It links against libmpv, so mpv in depends isn't needed... But does it actually touch wlroots?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah right wlroots and mpv don't seem to be explicitly needed in depends.

But it uses xdg-output-unstable-v1 and wlr-layer-shell-unstable-v1 so shouldn't we specify wlroots in depends as a safe guard (since it only works in wlroots based compositors)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. You can implement wlr protocols without being wlroots based, even.

Copy link
Member

@ericonr ericonr Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the need for wlroots-devel, though.

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label May 16, 2022
@github-actions github-actions bot closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants