New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: mpvpaper-1.1 #29962
New package: mpvpaper-1.1 #29962
Conversation
Needs I'd like to wait for a wlroots release before merging this, to see how they work with it. |
I tested briefly on hikari, river, sway and wayfire. |
@ericonr good to merge? |
srcpkgs/mpvpaper/template
Outdated
makedepends="mpv-devel wlroots-devel" | ||
depends="mpv wlroots" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It links against libmpv
, so mpv
in depends
isn't needed... But does it actually touch wlroots
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah right wlroots
and mpv
don't seem to be explicitly needed in depends.
But it uses xdg-output-unstable-v1 and wlr-layer-shell-unstable-v1 so shouldn't we specify wlroots
in depends as a safe guard (since it only works in wlroots based compositors)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. You can implement wlr protocols without being wlroots based, even.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the need for wlroots-devel
, though.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
General
Have the results of the proposed changes been tested?