Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk-configure: update to 0.37.0. #30110

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Conversation

mobinmob
Copy link
Contributor

@mobinmob mobinmob commented Apr 9, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

@ericonr
Copy link
Member

ericonr commented Apr 9, 2021

Clean the musl specific part from pre_check, it's no longer valid.

The bmake error failure seems to be due to an extra bmake error message? (It happens on the previous version as well)

~/v/void-packages master [~5] 😨 31s ➜ cat masterdir/builddir/mk-configure-mk-configure-0.36.0/tests/test_subprj_dash/expect.out
Dash symbol is not allowed inside subdir (another-one prog100-500)
~/v/void-packages master [~5] 😨 ➜ cat masterdir/builddir/mk-configure-mk-configure-0.36.0/tests/test_subprj_dash/test_subprj_dash.test.out

Dash symbol is not allowed inside subdir (another-one prog100-500)
bmake: stopped in /objdir

@mobinmob
Copy link
Contributor Author

mobinmob commented Apr 9, 2021

Clean the musl specific part from pre_check, it's no longer valid.

The bmake error failure seems to be due to an extra bmake error message? (It happens on the previous version as well)

~/v/void-packages master [~5] 😨 31s ➜ cat masterdir/builddir/mk-configure-mk-configure-0.36.0/tests/test_subprj_dash/expect.out
Dash symbol is not allowed inside subdir (another-one prog100-500)
~/v/void-packages master [~5] 😨 ➜ cat masterdir/builddir/mk-configure-mk-configure-0.36.0/tests/test_subprj_dash/test_subprj_dash.test.out

Dash symbol is not allowed inside subdir (another-one prog100-500)
bmake: stopped in /objdir

Yes, different output than expected. Removed the test and others that depend on it and added libbsd-devel to checkdepeds. It should work now - it is fine locally.

@mobinmob
Copy link
Contributor Author

mobinmob commented Apr 9, 2021

Added musl-fts-devel to checkdepends on musl.

@ericonr ericonr merged commit 9bdf7d9 into void-linux:master Apr 10, 2021
@mobinmob mobinmob deleted the mk-configure branch April 10, 2021 09:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants